-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bindgen for version 0.2.x of crate #82
Bump bindgen for version 0.2.x of crate #82
Conversation
Signed-off-by: Ionut Mihalcea <[email protected]>
A new script is added to aid the regeneration of bindings whenever the bindgen version is changed, along with the bindings produced with bindgen v0.59.2. Signed-off-by: Ionut Mihalcea <[email protected]>
I'll port this to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 also - nice to see some improvements that the new bindings bring e.g. #[derive(Debug)]
for generated structs.
Signed-off-by: Ionut Mihalcea <[email protected]>
Update the script to make it shell-compliant. Update the MacOS Darwin bindings, and change bindings OS name from `unknown` to `apple`. Add this target to the list supported by the script. Update the `build.rs` file to use correct `bindgen` methods. Co-authored-by: Ionut Mihalcea <[email protected]> Co-authored-by: Anton Antonov <[email protected]> Signed-off-by: Ionut Mihalcea <[email protected]>
6262d1c
to
71b7b7c
Compare
I've updated the script to include the MacOS bindings as well, for some reason we had them down as |
Signed-off-by: Ionut Mihalcea <[email protected]>
Signed-off-by: Ionut Mihalcea <[email protected]>
I've created a separate branch for the
0.2.x
versions of the crate, with the hope of using that for Parsec until we can update to0.3.0
. A new release is needed on our side specifically for an update of thebindgen
dependency, which this PR addresses. However, I plan to also update the committed bindings, hence this PR being a draft. This plan includes a bash script for regenerating those bindings when needed.cc. @vkkoskie